Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added schemas and specifications for data retrieved from Google Places API. #352

Merged
merged 8 commits into from
Sep 18, 2023
Merged

Added schemas and specifications for data retrieved from Google Places API. #352

merged 8 commits into from
Sep 18, 2023

Conversation

this-Aditya
Copy link
Member

Changes:

Added google_places_info schema.
Created specification google_places-1.0.0, included specifications for google places API.

Fixes #350

mpgxvii
mpgxvii approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@mpgxvii mpgxvii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yatharthranjan
yatharthranjan reviewed Aug 17, 2023
View reviewed changes
commons/passive/google/google_places_info.avsc Outdated
"type": "array", "items": {
"name": "PlacesType",
"type": "enum",
"doc": "Categories of places based on their characteristics or attributes.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNKNOWN can be removed from the enum list if not required.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@this-Aditya
Copy link
Member Author

Hi, @yatharthranjan I also removed ADMINISTRATIVE_AREA_LEVEL_6 and ADMINISTRATIVE_AREA_LEVEL_7 too, as they are not available from Places API.

@this-Aditya
Copy link
Member Author

this-Aditya commented Aug 17, 2023 •
edited
Loading

Should I also update the else block of when to null in radar-commons-android GooglePlacesManager here: (else -> PlacesType.UNKNOWN)

@yatharthranjan
Copy link
Member

yes please.

@this-Aditya
Copy link
Member Author

Hi, I've made the suggested updates to the schemas and will make the required changes in GooglePlacesManager.

@this-Aditya this-Aditya linked an issue Aug 22, 2023 that may be closed by this pull request
Create schemas for places API data. #350
Closed
yatharthranjan
yatharthranjan approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@this-Aditya
Copy link
Member Author

Hi, if this PR looks fine, can it be merged so that I can test data uploading for this plugin locally?
Thanks.

blootsvoets
blootsvoets approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blootsvoets blootsvoets merged commit 8154fb5 into RADAR-base:dev Sep 18, 2023
2 checks passed
@this-Aditya this-Aditya deleted the google-places branch September 18, 2023 08:06
@mpgxvii mpgxvii mentioned this pull request Oct 10, 2023
Merged
@this-Aditya this-Aditya mentioned this pull request Jun 3, 2024
Merged
@this-Aditya this-Aditya mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpgxvii mpgxvii mpgxvii approved these changes

@yatharthranjan yatharthranjan yatharthranjan approved these changes

@blootsvoets blootsvoets blootsvoets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create schemas for places API data.
4 participants
@this-Aditya @yatharthranjan @blootsvoets @mpgxvii