-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using PairState enum for paired status of remote bluetooth device. #362
Conversation
@@ -8,6 +8,11 @@ | |||
{"name": "timeReceived", "type": "double", "doc": "Device receiver timestamp in UTC (s)."}, | |||
{"name": "macAddressHash", "type": ["null", "bytes"], "default": null, "doc":"Hash of Nearby Bluetooth device MAC address."}, | |||
{"name": "hashSaltReference", "type": ["null", "int"], "doc": "Random identifier associated with the device or installation of the app. If the app gets reinstalled or installed on another device, it's clear during analysis that the mac addresses between iterations are not comparable.", "default": null}, | |||
{"name": "isPaired", "type": ["null","boolean"], "doc": "Whether the bluetooth device is paired.", "default": null} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not delete this owing to schema evolution and backwards compatibility. You can keep this as is and update the doc to say this is deprecated in favour of pairedState in newer versions.
As a rule, we never delete any fields and always add null default in new fields in any existing schema.
PS: nice spot @afolarin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, nice to know about it. I will be updating this accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
Merging to include in 0.8.7 release |
Earlier the pairing state of the remote device is calculated manually, but there is also a straightforward and precise way here.