-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix basic authentication during schema registry init #369
Conversation
6e3ce3b
to
9437b4d
Compare
Solves #368 Testing this on the dev server now :) |
We should merge to dev, and see how to release this asap. 0.8.7-hotfix or 0.8.8? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some style fixes needed
...radar-schemas-registration/src/main/java/org/radarbase/schema/registration/SchemaRegistry.kt
Show resolved
Hide resolved
I can't get the derived MorePlatform docker image to work unfortunately. This might be due to erroneous building, there is a script missing and I have seen it before.
If you tested it locally I would be ok merging, releasing a hotfix from the dev branch and testing it that way |
9437b4d
to
21a2298
Compare
69e2406
to
5ec4a9b
Compare
Problem
During initialization of schema registry the following error was thrown:
The cause was that basic authentication headers were not sent during init where the schema registry requests the
/subjects
endpoint.Solution
A basic auth header was added so that the request succeeds.
Note
Basic auth headers appeared to be set at a global scale for the Ktor HttpClient. However, these do not appear to work for the
/subjects
call during init. To make sure we do not run into problems elsewhere I added thesendWithoutRequest
param to the global HttpClient config (see docs).