Enhanced fetching of Definitions via radar-self-enrolment-definitions #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this-Aditya
commented
Aug 14, 2024
| @@ -103,4 +112,21 @@ const EligibilityForm: React.FC<EligibilityFormProps> = ({ | |||
| </MarginCard> | |||
| ) | |||
|
|
|||
| export const getServerSideProps: GetServerSideProps = async (context) => { | |||
| const {projectId} = context.query | |||
There was a problem hiding this comment.
I couldn't find a way to use sessionStorage in getServerSideProps, so I am also utilizing projectId in both the eligibility and study-consent pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated definitions fetching from radar-self-enrolment-definitions instead of fetching locally.
This implementation utilizes
data-cacheandcached-recordto cache content received from GitHub for a specified duration. This approach reduces the need for multiple network calls to the same endpoints, particularly in cases of page refreshes or frequent revisits.@yatharthranjan @mpgxvii @Bdegraaf1234 , please review this pull request and provide feedback if any improvements are needed.
Fixes: #13