Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added verification of projects from Management Portal for study page #19

Merged
merged 8 commits into from
Aug 26, 2024
Merged

Added verification of projects from Management Portal for study page #19

merged 8 commits into from
Aug 26, 2024

Conversation

this-Aditya
Copy link
Member

Fixes #17

yatharthranjan
yatharthranjan reviewed Aug 22, 2024
View reviewed changes
Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. just a couple of minor comments.

config/github-config.ts Outdated Show resolved Hide resolved
pages/study.tsx Outdated Show resolved Hide resolved
mpgxvii
mpgxvii approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@mpgxvii mpgxvii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this! Also, would it be possible to run Prettier? npm run format

pages/study.tsx Outdated Show resolved Hide resolved
pages/study.tsx Outdated
REMOTE_DEFINITIONS_CONFIG.STUDY_INFO_DEFINITION_FILE_NAME_CONTENT, REMOTE_DEFINITIONS_CONFIG.STUDY_INFO_VERSION)
try {
const fetchedProjects: Project[] = await fetchProjectsFromMp()
console.log(fetchedProjects)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove this log?

this-Aditya and others added 3 commits August 23, 2024 20:47
@this-Aditya
Copy link
Member Author

Merging this PR because running Prettier also formatted the files for the fetch-definitions branch. Merging these changes will provide a cleaner structure for review in that PR.

@this-Aditya this-Aditya merged commit 5f85e34 into fetch-definitions Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatharthranjan yatharthranjan yatharthranjan left review comments

@mpgxvii mpgxvii mpgxvii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@this-Aditya @yatharthranjan @mpgxvii