-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial enrolment flow #9
Conversation
…fore registration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, excellent work!
Please take a look at some comments below. Most, if not all, of these can be done in separate issues/PRs later.
As discussed before, it would be good to abstract most of the input types so they can be reused across various pages.
id={question.field_name} | ||
name={question.field_name} | ||
type={question.field_type} | ||
required={isRequired} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to support various input types
implement your own custom user interface. | ||
</P> | ||
<CardTitle>RADAR Base Ory!</CardTitle> | ||
<P>Welcome to the RADAR Base self-enrolment portal.</P> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should be customisable based on the project
pages/index.tsx
Outdated
href="https://www.ory.sh/docs/get-started" | ||
testid="get-started" | ||
testid="study" | ||
href="/study" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be project-specific? like/study?ref=STAGING_PROJECT
or /study/STAGING_PROJECT
return ( | ||
<> | ||
<Head> | ||
<title>Profile Page</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need something generic here that can parse as many Identifiable questionnaires as necessary
pages/settings.tsx
Outdated
flow={flow} | ||
/> | ||
<div> | ||
<H3>Profile Settings</H3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would happen to the apps and others that are based on email when email is changed? Would they logout? If so we should show a warning on updating of emails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will test with aRMT integration.
pages/study.tsx
Outdated
question.select_choices_or_calculations.map((info, idx) => ( | ||
<div key={`${index}-${idx}`}> | ||
<label className="inputLabel">{info.code}</label> | ||
<InnerCard>{info.label}</InnerCard> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also store study info if there are any input types apart from info or descriptive text.
</Head> | ||
<MarginCard> | ||
<CardTitle>Create account</CardTitle> | ||
<CardTitle>Create Your Account</CardTitle> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need explicit consent for RADAR-Base specific terms and conditions here before an account can be created, these should also be recorded in identity traits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Pauline,
Overall, this PR looks excellent. I’ve left some comments focused on minor enhancements. Please take a look at these comments and make any adjustments you deem appropriate.
@mpgxvii Can you also run Prettier to fix the formatting issues? |
566db81
to
5beee61
Compare
…se/radar-self-enrolment-ui into feat/consent-module
…ent-ui into feat/consent-module
…se/radar-self-enrolment-ui into feat/consent-module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Pauline,
I think the others reviewed this better than I could have, LGTM
…ent-ui into feat/initial-components
…se/radar-self-enrolment-ui into feat/consent-module
Co-authored-by: Aditya Mishra <98681758+this-Aditya@users.noreply.github.com>
Add initial hydra consent module
Solves: