Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up RdCore Installation with docker #44

Open
wants to merge 2 commits into
base: cake4
Choose a base branch
from

Conversation

akoharu
Copy link

@akoharu akoharu commented Sep 23, 2023

This PR is to tidy up the docker files and make them easier to maintain.
The previous docker setup makes duplicate copies of the code and is not easy to maintain.

This PR will:

  • Move the docker-compose files to the root of the project
  • rename the Dockerfile-build-radiusdesk to Dockerfile and move it to the root of the project
  • rename the local_build.sh to docker_build.sh and move it to the root of the project
  • update the docker_build.sh to match with the new project structure

Testing

  • Run the docker_build.sh script
  • Access the radiusdesk web interface

@akoharu akoharu marked this pull request as draft September 23, 2023 18:26
@akoharu akoharu marked this pull request as ready for review September 23, 2023 18:26
@jahknem
Copy link

jahknem commented Jul 5, 2024

Why has this not been merged yet? I'm also currently debugging why the docker image will nto start and this would probably have helped a lot.

1 similar comment
@jahknem
Copy link

jahknem commented Jul 5, 2024

Why has this not been merged yet? I'm also currently debugging why the docker image will nto start and this would probably have helped a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants