-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnrc/ipv6/nib: make ABR run-time configurable #21081
base: master
Are you sure you want to change the base?
Conversation
9708b0b
to
08cf592
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to have a deeper look into this as the designated GNRC / NIB expert but that may take a while. For now soft-blocking. If I don't come to it until end of February, please dismiss my change request.
(also please don't hesitate to remind me each time there is a Hack'n'ACK around the corner ;-)) |
So, the default behavior stays the same for a 6lbr but we can configure it to be non-authorative with this patch, right? |
Yes that's the idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to test this before I give an ACK but code-wise the change looks sane to me.
* @brief activate authoritative border router functionality at interface start-up | ||
*/ | ||
#ifndef CONFIG_GNRC_IPV6_NIB_ABR | ||
#define CONFIG_GNRC_IPV6_NIB_ABR CONFIG_GNRC_IPV6_NIB_6LBR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can add a line to the docs of the border router (or border router example?) about how to possibility to make a 6lbr non-authorative.
Contribution description
Currently all nodes compiled with
gnrc_sixlowpan_border_router_default
will act as an authoritative border router by default.We have a setup with many wireless nodes that are all potential (authoritative) border routers (see #21080), but only one of them will be selected (at run-time) to do so.
This adds a
NETOPT_6LO_ABR
that can be used to enable / disable the authoritative border router functionality on an interface as well as aCONFIG_GNRC_IPV6_NIB_ABR
to control the start-up default.Testing procedure
Issues/PRs references