Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc/ipv6/nib: make ABR run-time configurable #21081

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

benpicco
Copy link
Contributor

Contribution description

Currently all nodes compiled with gnrc_sixlowpan_border_router_default will act as an authoritative border router by default.

We have a setup with many wireless nodes that are all potential (authoritative) border routers (see #21080), but only one of them will be selected (at run-time) to do so.

This adds a NETOPT_6LO_ABR that can be used to enable / disable the authoritative border router functionality on an interface as well as a CONFIG_GNRC_IPV6_NIB_ABR to control the start-up default.

Testing procedure

Issues/PRs references

@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels Dec 13, 2024
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to have a deeper look into this as the designated GNRC / NIB expert but that may take a while. For now soft-blocking. If I don't come to it until end of February, please dismiss my change request.

@miri64
Copy link
Member

miri64 commented Dec 13, 2024

(also please don't hesitate to remind me each time there is a Hack'n'ACK around the corner ;-))

@OlegHahm
Copy link
Member

So, the default behavior stays the same for a 6lbr but we can configure it to be non-authorative with this patch, right?

@benpicco
Copy link
Contributor Author

Yes that's the idea.

Copy link
Member

@OlegHahm OlegHahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to test this before I give an ACK but code-wise the change looks sane to me.

sys/net/gnrc/network_layer/ipv6/nib/nib.c Show resolved Hide resolved
* @brief activate authoritative border router functionality at interface start-up
*/
#ifndef CONFIG_GNRC_IPV6_NIB_ABR
#define CONFIG_GNRC_IPV6_NIB_ABR CONFIG_GNRC_IPV6_NIB_6LBR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can add a line to the docs of the border router (or border router example?) about how to possibility to make a 6lbr non-authorative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: sys Area: System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants