Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Block warnings (with warnings fixes) #106

Merged
merged 6 commits into from
Aug 21, 2024
Merged

CI: Block warnings (with warnings fixes) #106

merged 6 commits into from
Aug 21, 2024

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Aug 21, 2024

This adds the equivalent of -Werror to the CI builds.

While this is generally discouraged (for it means that new Rust versions break CI), in this case we don't get new Rust versions all the time but only on riotdocker updates, and that's a good time to reflect on whether the new warnings make sense or not.

Let's see how well that works; I rather add #[allow(...)] generously in the codebase than have so many warnings that important ones get overshadowed.

Along with the actual change, all the fixes that would previously have caused warnings (now errors) come in.

@chrysn chrysn enabled auto-merge August 21, 2024 21:47
@chrysn chrysn merged commit 3ded2cf into main Aug 21, 2024
67 checks passed
@chrysn chrysn deleted the warnings-block branch August 21, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant