vfs: Buffer names for nul termination #107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a severe bug where file names were passed to the C API that expects nul-termination.
This incurs some copying overhead, which fortunately is not too bad due to the name length limit.
Closes: #93
Thanks @maikerlab for reporting this. AIU it went unnoticed because in my tests, the &str often came from what was originally nul-terminated, eg. from the command line, or from CoAP where the option byte is sometimes replaced with a \0 as a part gcoap's internal processing.