-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start implementation of general settings #115
Conversation
As suggested in RIP-Comm#70, I added a new section (general setting) in the page settings, which will have general settings like light/dark mode and currency selector. I haven't started to implement the page because it hasn't been defined on Figma yet.
This reverts commit 52963cb.
Hi @0xbaggi ! Since I haven't heard back from the guy who was working on #70 if you want you can start implementing that part in the general settings. Personally I wouldn't wait for the figma since this is a small part of the app and there shouldn't be many problems with it. |
I added some static buttons in the general settings page, their functionalities have yet to be implemented.
Screen_recording_20230913_232758.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi I would remove the language picker (or we can keep the code and just avoid displaying it) for now since we won't support other languages before version 1.0.
I see that the check failed with this message:
The current Dart SDK version is 2.18.0.
Because sossoldi depends on country_flags >=2.1.0 which requires SDK version >=3.0.0 <4.0.0, version solving failed.
We should probably look into that, we might think about using the emojis for the flags (Ex. 🇮🇹, 🇬🇧, 🇩🇪, 🇫🇷) instead of something external.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and the check passed, @mikev-cw if you are ok with that I think we can merge this
@theperu if you already checked, it's enough. Let's merge! |
As suggested in #70, I added a new section (general setting) in the page settings, which will have general settings like light/dark mode and currency selector. I haven't started to implement the page because it hasn't been defined on Figma yet.