-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/budget #158
Feature/budget #158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that's very cool!!!
I just made some minor notes, but I've nothing to say about the overall approach.
Also keep an eye to those brand new conflicts.
About this:
I added the ability to delete the budget via swipe. In the UI, there was both that option and the option through a "-" button next to the budget. We need to decide which one to keep.
It seems that in the design file @federicopozzato has planned kind of "edit mode", where user can tap the "-" button to delete a budget, but since you can in fact edit all about budgets when you press "Manage", actually having an extra edit mode can be a bit redundant at this stage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the implementation, good job! I left a couple of comments for minor changes but apart from that it seems fine to me.
Since you have already done the work on the budgets could you also work on the graphs that are at the bottom of the Dashboard next?
FYI I just noticed that there are also some conflicts that need to be resolved before we can merge
PR updated! Let me know if i can help |
I'm sending you the pull request for the implementation of the Budgets feature, just to keep you informed about the direction I took during development.
Some points of attention already known:
For any doubts, questions, or suggestions, feel free to reach out!