Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onboarding and minor layout fixes #162

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Conversation

fres-sudo
Copy link

the minor layout fixes regards:

  • month selector
  • budgets provider (create another method "insertOrUpdates" in the budgets provider is also possible)
  • add category page
  • routes

@theperu
Copy link
Collaborator

theperu commented Mar 29, 2024

Nice work! Most of the things look good to me, I just noticed a couple of issue that need to be fixed before merging:

  1. When I close and reopen the app I see the onboarding again. Once the user completes the Onboarding the first time they should skip to the dashboard.
  2. When I add the main account I can only input a number without the decimal points (Ex. I can add 3000 but not 3000.01)

Here is a video:
https://drive.google.com/file/d/1kiv-2eVfrE10KS8I2Y6FAEKEElZP4ypB/view?usp=drive_link

@fres-sudo
Copy link
Author

Damn, I implement the one-time onboarding feature but for testing purpouse i commented it.
The idea was to uncomment it but i just forgot before committing >.<.
As you can see in main.dart at line 47/48 ther's the correct line and a TODO that explains everythings.

For the decimal point i'll take a look and see what i can do.

Thanks!

…ber input, add method to set currency at the start of the application
Copy link
Collaborator

@theperu theperu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucaantonelli now it seems fine to me, if you agree we can merge 🙂

@lucaantonelli lucaantonelli merged commit 7aa5bd7 into RIP-Comm:main Apr 22, 2024
1 check passed
@mikev-cw mikev-cw mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants