Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring recurring transactions #167

Merged
merged 32 commits into from
Nov 3, 2024
Merged

Conversation

mikev-cw
Copy link
Collaborator

@mikev-cw mikev-cw commented Apr 26, 2024

This aims to address #144. I focused on Backend operations only.

Removed recurring_transaction_amount model, and added recurring_transaction.
Now we've a table that list recurring transactions. When the app is opened, not more than once a day thanks to shared preferences, system will check if a transaction (or more) is needed, and adds them to the transaction table, based on their recurrency type.

Also changed the behavior of "clear db" button on settings: now it re-generates all tables. This is useful when we edit models: there will no more need to delete database from OS.
To check this PR, just chekout, run, press "reset DB" and fill with demo data.

I'm leaving this in draft for now: i need to go deeper on some behaviors, update tests, and remove some dev debug code.
Meanwhile feel free to share your opinions if you want.
Also if anyone wants to help with frontend, which I am not very familiar with, it would help.

EDIT: I'm opening this PR for review. We've also covered the front-end stuff with the help of @K-w-e.
Now when an user edits or creates a transaction, all pages will prevent or require the user to change recurrence data, based on the logic we defined.

Also: bumped the version of flutter_local_notifications, and -as per our last meeting- fixed the version of Flutter SDK to 3.24.3

@mikev-cw mikev-cw added help wanted Extra attention is needed backend This is backend related labels Apr 26, 2024
@K-w-e
Copy link
Contributor

K-w-e commented Apr 28, 2024

I can help with the frontend changes.
I'll work on the recurring transactions display section.

@mikev-cw
Copy link
Collaborator Author

@K-w-e Thank you, it would be great!
There's also how the add_page.dart reads and writes recurring data. Not checked yet how that part needs to be implemented.
Reach me any time if you need help, i plan to open this PR for review within this week.

@mikev-cw mikev-cw removed the help wanted Extra attention is needed label May 7, 2024
@gioisco gioisco mentioned this pull request Aug 19, 2024
3 tasks
@mikev-cw mikev-cw marked this pull request as ready for review October 29, 2024 22:12
@mikev-cw
Copy link
Collaborator Author

mikev-cw commented Oct 29, 2024

I opened this for review. Reporting below the updated first comment:

Removed recurring_transaction_amount model, and added recurring_transaction.
Now we've a table that list recurring transactions. When the app is opened, not more than once a day thanks to shared preferences, system will check if a transaction (or more) is needed, and adds them to the transaction table, based on their recurrency type.

Also changed the behavior of "clear db" button on settings: now it re-generates all tables. This is useful when we edit models: there will no more need to delete database from OS.
To check this PR, just chekout, run, press "reset DB" and fill with demo data.

[...]

I'm opening this PR for review. We've also covered the front-end stuff with the help of @K-w-e.
Now when an user edits or creates a transaction, all pages will prevent or require the user to change recurrence data, based on the logic we defined.

Also: bumped the version of flutter_local_notifications, and -as per our last meeting- fixed the version of Flutter SDK to 3.24.3

@lucaantonelli lucaantonelli merged commit 5fbdbd6 into RIP-Comm:main Nov 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This is backend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants