Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding Page #56

Closed
wants to merge 0 commits into from
Closed

Onboarding Page #56

wants to merge 0 commits into from

Conversation

0xbaggi
Copy link
Contributor

@0xbaggi 0xbaggi commented Jan 11, 2023 •
edited
Loading

I develop the onboarding page (#39), following the figma design:

done:

  • "start the set up" page
  • step 1 page (set budgets)
  • Scrollable list of selectable budgets as a grid of cards
  • "add category" card
  • Dynamic style and layout (based on selected budget cards)
  • step 2 page (set liquidity)
  • Input fields for account name and ammount (with numeric keypad only.)

TODO:

  • Show onboarding page only the first time

(step 1 page)

  • Dynamic budgets from database (now they are static)
  • implement the function onTap on the "Add category" card

(step 2 page)

  • implement the "edit icon and color" field input
ezgif-5-add2d1b48f.mp4

tested on Pixel XL API 31 Android 12

lucaantonelli
lucaantonelli reviewed Jan 12, 2023
View reviewed changes
lib/main.dart Outdated
@@ -3,7 +3,7 @@ import 'dart:io';

import 'package:flutter/material.dart';
import 'routes.dart';
import 'pages/structure.dart';
import 'package:sossoldi/pages/onboarding_page.dart';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use relative path as mentioned in #43 . Check also the other files commited to update it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the best choice is to use relative path :'D

Copy link
Contributor Author

@0xbaggi 0xbaggi Jan 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I just made a commit to fix this.
I think there are others incorrectly named import in the project, maybe its needed a issue for check all files.

FedericoBruzzone
FedericoBruzzone requested changes Jan 12, 2023
View reviewed changes
lib/main.dart Outdated
@@ -3,7 +3,7 @@ import 'dart:io';

import 'package:flutter/material.dart';
import 'routes.dart';
import 'pages/structure.dart';
import 'package:sossoldi/pages/onboarding_page.dart';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the best choice is to use relative path :'D

FedericoBruzzone
FedericoBruzzone requested changes Jan 12, 2023
View reviewed changes
lib/pages/onboarding_page.dart Outdated
Comment on lines 82 to 89
List<BudgetWrap> budgets = [
BudgetWrap("Home", 400, Colors.orange),
BudgetWrap("Free time", 100, Colors.blue),
BudgetWrap("Health", 100, Colors.pinkAccent),
BudgetWrap("Savings", 150, Colors.red),
BudgetWrap("Travel", 50, Colors.lightBlueAccent),
BudgetWrap("Shopping", 50, Colors.yellow),
];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The amount should be decided by the user right? (I now this part is for testing)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I think the user will create his own custom budget and amount, but at the moment it is statically defined in this list (like names and colors).

@FedericoBruzzone
Copy link
Collaborator

Can you open the issues regarding the things that are missing?

@0xbaggi
Copy link
Contributor Author

0xbaggi commented Jan 14, 2023

Can you open the issues regarding the things that are missing?

Sure, #57
I think we should label it as a "good first issue"

@FedericoBruzzone
Copy link
Collaborator

Can I merge this staff? :D

@mikev-cw
Copy link
Collaborator

@FedericoBruzzone Remember merging is paused for some days

@FedericoBruzzone
Copy link
Collaborator

Thanks for reminding me, write me when I can merge @mikev-cw

@0xbaggi
Copy link
Contributor Author

0xbaggi commented Jan 23, 2023

@FedericoBruzzone @mikev-cw
Can we merge this now?

@FedericoBruzzone
Copy link
Collaborator

FedericoBruzzone commented Jan 23, 2023 •
edited
Loading

Can we merge this now?

I'm waiting for them to tell me to proceed

@mikev-cw
Copy link
Collaborator

@0xbaggi merging of #63 has raised some expected conflicts. Can you check if you can easily resolve them? Head on Discord if you need help

@mikev-cw mikev-cw linked an issue Jan 23, 2023 that may be closed by this pull request
Onboarding #39
Closed
@FedericoBruzzone
Copy link
Collaborator

You should update your fork, after that you can use this command locally:

git switch main
git pull main
git switch -
git rebase main

and at this point resolve conflicts in your favorite text editor.

Please, don't create another commit, after the above command use git commit --amend & git push --force to update this pull request.

@0xbaggi 0xbaggi closed this Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaantonelli lucaantonelli lucaantonelli left review comments

@FedericoBruzzone FedericoBruzzone FedericoBruzzone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Onboarding
4 participants
@0xbaggi @FedericoBruzzone @mikev-cw @lucaantonelli