Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

replace code_level with nchar #29

Merged
merged 2 commits into from
Mar 14, 2024
Merged

replace code_level with nchar #29

merged 2 commits into from
Mar 14, 2024

Conversation

jacobvjk
Copy link
Member

closes #18

  • replaces max(code_level) with max(nchar(code)) to identify sector codes at the most granular level, as code_level was deprecated from r2dii.data

@jacobvjk jacobvjk requested a review from jdhoffa March 14, 2024 12:10
jdhoffa
jdhoffa previously approved these changes Mar 14, 2024
View reviewed changes
@jacobvjk jacobvjk merged commit 05e7138 into main Mar 14, 2024
16 of 17 checks passed
@jacobvjk jacobvjk deleted the 18-rm-code-level branch March 14, 2024 12:17
@jdhoffa
Copy link
Member

jdhoffa commented Mar 14, 2024

@AlexAxthelm @jacobvjk @cjyetman
This is a situation where I can see the "Version check" check becoming a bit annoying.
This package has not even reached a "first release" yet, so bumping the dev version every PR seems like it could get a bit excessive, what do you all think?

@jacobvjk
Copy link
Member Author

tend to agree

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jdhoffa jdhoffa jdhoffa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upkeep: create_benchmark_loanbook() cannot use code_level from r2dii.data anymore
2 participants
@jacobvjk @jdhoffa