Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for MacOS Sonoma running R < 4.3.2 #57

Closed
wants to merge 1 commit into from

Conversation

AlexAxthelm
Copy link
Collaborator

In MacOS Sonoma (Darwin version 23), iconv() can cause an R-fatal error when converting non-ASCII characters to ASCII.

See https://groups.google.com/g/r-sig-mac/c/pFuJu7F33Eg/m/xdrBmg-PDwAJ for more discussion.
Closes #54

@cjyetman
Copy link
Member

"Warning: In Darwin release 23.0.0 (MacOS Sonoma 14.0) or higher,\n",
"an issue with `iconv` causes R to crash when converting ",
"Non-ASCII characters to ASCII.\n",
"You are running R version ", r_version,
" on Darwin release ", darwin_version, ".\n",
"Please ensure that portfolios imported with ", pkgname,
" contain only ASCII characters,\n",
"or update R to version 4.3.2 or higher.\n"

This is neither entirely correct nor specifically scoped to the actual problem, as far as I understand.

The problem is specific to using the sub argument of iconv on a string that contains a " followed by an extended character on <= R v4.3.1 and macOS Sonoma (Darwin version 23) or higher

@AlexAxthelm
Copy link
Collaborator Author

Closing in favor of #58 which solves the actual problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

encoding test crashes R session on macOS
2 participants