Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for multiple trailing and/or leading whitespace in header #63

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

cjyetman
Copy link
Member

No description provided.

Copy link

Coverage Report
file head main diff
Overall 58% 58% 0%
R/canonize_path.R 91% 91% 0%
R/determine_headers.R 72% 72% 0%
R/get_csv_specs.R 0% 0% 0%
R/guess_delimiter.R 100% 100% 0%
R/guess_file_encoding.R 89% 89% 0%
R/guess_numerical_mark.R 94% 94% 0%
R/has_binary_null.R 100% 100% 0%
R/has_consistent_fields_per_line.R 100% 100% 0%
R/has_newline_at_end.R 96% 96% 0%
R/is_file_accessible.R 100% 100% 0%
R/is_readable_file.R 100% 100% 0%
R/is_text_file.R 100% 100% 0%
R/is_valid_currency_code.R 100% 100% 0%
R/is_valid_cusip.R 100% 100% 0%
R/is_valid_isin.R 100% 100% 0%
R/read_portfolio_csv.R 86% 86% 0%
R/simplify_if_one_col_df.R 100% 100% 0%

@cjyetman cjyetman changed the title allow for multiple trailing and or leading whitespace in header allow for multiple trailing and/or leading whitespace in header Jan 13, 2024
@AlexAxthelm
Copy link
Collaborator

@cjyetman I've added a few more tests for more complicated whitespace padding (don't laugh, I've seen these in the wild at other jobs)

@cjyetman
Copy link
Member Author

Checking for tabs seems reasonable to me. Pretty sure the regex should cover any whitespace including tab.

@cjyetman cjyetman merged commit 8e2543d into main Jan 15, 2024
8 checks passed
@cjyetman cjyetman deleted the allow-multiple-trailing-whitespace branch January 15, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants