Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reimplement identifying files with a trailing return as having a newline #78

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman commented Feb 2, 2024

closes #77

Copy link

github-actions bot commented Feb 2, 2024

Coverage Report
file head main diff
Overall 62% 61% ⬆️ 1.1%
R/canonize_path.R 91% 91% 0%
R/char_to_.R 0% 0% 0%
R/determine_header_types.R 92% 92% 0%
R/determine_headers.R 87% 87% 0%
R/get_csv_specs.R 0% 0% 0%
R/guess_delimiter.R 100% 100% 0%
R/guess_file_encoding.R 89% 89% 0%
R/guess_numerical_mark.R 94% 94% 0%
R/has_binary_null.R 100% 100% 0%
R/has_consistent_fields_per_line.R 100% 100% 0%
R/has_header.R 89% 89% 0%
R/has_newline_at_end.R 100% 66% ⬆️ 34%
R/is_file_accessible.R 100% 100% 0%
R/is_readable_file.R 100% 100% 0%
R/is_text_file.R 100% 100% 0%
R/is_valid_currency_code.R 100% 100% 0%
R/is_valid_cusip.R 100% 100% 0%
R/is_valid_isin.R 100% 100% 0%
R/read_first_line.R 88% 88% 0%
R/read_portfolio_csv.R 88% 88% 0%
R/simplify_if_one_col_df.R 100% 100% 0%

Copy link
Collaborator

@AlexAxthelm AlexAxthelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@cjyetman cjyetman merged commit c089e73 into main Feb 2, 2024
8 checks passed
@cjyetman cjyetman deleted the cjyetman-patch-1 branch February 2, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

most recent version of Microsoft Excel for Mac does export CSV files with "\r" as the line ending
2 participants