Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change from summarise to reframe #15

Merged
merged 3 commits into from
Sep 20, 2023
Merged

change from summarise to reframe #15

merged 3 commits into from
Sep 20, 2023

Conversation

AlexAxthelm
Copy link
Collaborator

cjyetman
cjyetman requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@cjyetman cjyetman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think .groups is not a valid argument for reframe()

@cjyetman
Copy link
Member

Also... have you verified that "Returning more (or less) than 1 row per `summarise()` group" is something we expect to happen here?

@cjyetman cjyetman merged commit dc98d15 into main Sep 20, 2023
7 checks passed
@cjyetman cjyetman deleted the feature/fix-summarise branch September 20, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyetman cjyetman cjyetman approved these changes

@MonikaFu MonikaFu Awaiting requested review from MonikaFu MonikaFu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switch from summarise() to reframe()
2 participants
@AlexAxthelm @cjyetman