Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove TDM from GENERAL reports #39

Merged
merged 1 commit into from
Dec 1, 2023
Merged

remove TDM from GENERAL reports #39

merged 1 commit into from
Dec 1, 2023

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman commented Nov 29, 2023 •
edited
Loading

@cjyetman cjyetman mentioned this pull request Nov 29, 2023
Merged
jacobvjk
jacobvjk approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me, although not having worked much on P4I lately, I would feel more comfortable with an additional review

MonikaFu
MonikaFu approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@MonikaFu MonikaFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjyetman cjyetman merged commit d31efc1 into main Dec 1, 2023
8 checks passed
@cjyetman cjyetman deleted the remove-TDM-from-GENERAL-reports branch December 1, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAxthelm AlexAxthelm AlexAxthelm approved these changes

@MonikaFu MonikaFu MonikaFu approved these changes

@jacobvjk jacobvjk jacobvjk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjyetman @AlexAxthelm @MonikaFu @jacobvjk