remove TDM code #41
Merged
remove TDM code #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy with removing it to be honest. I mean - including the JS code. In case we need it we can still find it in the old PRs and I am not sure anyway if this was the best visual for the data we were showing. I was kind of pressured to make it look the way it does. |
MonikaFu
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a bit torn about removing the speedometer JS code... it is, in it's current state, definitively, exclusively related to TDM, but maybe it could be useful for something else in the future? My instinct says that it should be removed along with anything else TDM exclusive in this PR, but I'm hesitating a bit. @MonikaFu thoughts? Should we stuff it somewhere else?