Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update export_report_content_variables_json #6

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Update export_report_content_variables_json #6

merged 3 commits into from
Jun 16, 2023

Conversation

MonikaFu
Copy link
Collaborator

@MonikaFu MonikaFu commented Jun 15, 2023 •
edited
Loading

Closes #5

In this PR I update the export_report_content_variables_json() in the following way:

  • Remove unused inputs, outputs, and calculations
  • Rename export_report_content_variables_json to sth more accurate
  • style

@MonikaFu MonikaFu merged commit d263e0c into main Jun 16, 2023
8 checks passed
@MonikaFu MonikaFu deleted the dont-calcuate-unused-portf-params branch June 16, 2023 10:54
@MonikaFu MonikaFu mentioned this pull request Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyetman cjyetman cjyetman approved these changes

@AlexAxthelm AlexAxthelm Awaiting requested review from AlexAxthelm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

export_report_content_variables_json() is outdated and doesn't calculate all values correctly
2 participants
@MonikaFu @cjyetman