Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep: add minimal unit testing #64

Merged
merged 3 commits into from
Apr 18, 2024
Merged

upkeep: add minimal unit testing #64

merged 3 commits into from
Apr 18, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Apr 16, 2024

This adds some minimal unit tests to the low-hanging fruit.

Obviously create_interactive_report is the real elephant in the room here, but I want to tackle that in a separate PR/ issue (see #63)

Screenshot 2024-04-16 at 11 29 45

Closes #30

@jdhoffa jdhoffa requested a review from MonikaFu as a code owner April 16, 2024 09:29
@jdhoffa jdhoffa requested a review from cjyetman April 16, 2024 09:33
Co-authored-by: CJ Yetman <cyetman@rmi.org>
Copy link
Collaborator

@MonikaFu MonikaFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdhoffa jdhoffa merged commit ceb6a95 into main Apr 18, 2024
7 checks passed
@jdhoffa jdhoffa deleted the 30-add_unit_tests branch April 18, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement testing
3 participants