Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: in tech mix, distinguish similarly named scenarios by prepending source #75

Merged
merged 2 commits into from
May 9, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented May 8, 2024

Maybe closes #74
Relates to AB#10962

Screenshot 2024-05-08 at 08 48 33

@jdhoffa jdhoffa requested a review from MonikaFu as a code owner May 8, 2024 15:49
@jdhoffa jdhoffa requested a review from cjyetman May 8, 2024 15:49
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 0.81%. Comparing base (a3010b7) to head (ec84c86).

Files Patch % Lines
R/prep_techexposure_future.R 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #75      +/-   ##
========================================
- Coverage   0.81%   0.81%   -0.01%     
========================================
  Files         25      25              
  Lines       1594    1595       +1     
========================================
  Hits          13      13              
- Misses      1581    1582       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdhoffa
Copy link
Member Author

jdhoffa commented May 8, 2024

@cjyetman @MonikaFu given that we barely have any tests in this repo together (and adding a good testing infrastructure is a large task unto itself), I would elect to ignore the 2 failing test coverage checks.

@cjyetman
Copy link
Member

cjyetman commented May 8, 2024

@cjyetman @MonikaFu given that we barely have any tests in this repo together (and adding a good testing infrastructure is a large task unto itself), I would elect to ignore the 2 failing test coverage checks.

I'm not a fan of Codecov failing tests because of lack of coverage. It's there to give us information, not tell us we shouldn't merge things.

@jdhoffa jdhoffa merged commit 5f0d2f2 into main May 9, 2024
9 of 11 checks passed
@jdhoffa jdhoffa deleted the 74-format_tech_mix_scenarios branch May 9, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scenario names in the tech mix need to be differentiated
2 participants