Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unicode escape for "CO₂" in prep_emissions_trajectory.R #80

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Use unicode escape for "CO₂" in prep_emissions_trajectory.R #80

merged 2 commits into from
Jun 6, 2024

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman commented Jun 1, 2024

@cjyetman cjyetman requested a review from MonikaFu as a code owner June 1, 2024 23:09
@codecov Codecov
Copy link

codecov bot commented Jun 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 0.81%. Comparing base (0c1837e) to head (ff45e12).

Files Patch % Lines
R/prep_emissions_trajectory.R 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff          @@
##            main     #80   +/-   ##
=====================================
  Coverage   0.81%   0.81%           
=====================================
  Files         25      25           
  Lines       1596    1596           
=====================================
  Hits          13      13           
  Misses      1583    1583

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jdhoffa
jdhoffa previously approved these changes Jun 3, 2024
View reviewed changes
MonikaFu added a commit to RMI-PACTA/workflow.transition.monitor that referenced this pull request Jun 4, 2024
@MonikaFu
Use branch CO\u2082-with-unicode-escape
b031512 
DO NOT MERGE
Testing PR: RMI-PACTA/pacta.portfolio.report#80
@MonikaFu MonikaFu mentioned this pull request Jun 4, 2024
Closed
MonikaFu
MonikaFu previously approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@MonikaFu MonikaFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjyetman cjyetman dismissed stale reviews from MonikaFu and jdhoffa via ff45e12 June 6, 2024 12:29
@cjyetman cjyetman requested review from jdhoffa and MonikaFu June 6, 2024 12:29
@cjyetman
Copy link
Member Author

cjyetman commented Jun 6, 2024

Sorry, had to re-request reviews to update with main

MonikaFu
MonikaFu approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@MonikaFu MonikaFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjyetman cjyetman merged commit 9a24a10 into main Jun 6, 2024
9 checks passed
@cjyetman cjyetman deleted the CO₂-with-unicode-escape branch June 6, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonikaFu MonikaFu MonikaFu approved these changes

@jdhoffa jdhoffa Awaiting requested review from jdhoffa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use subscript 2 in "CO₂" in emissions plot y-axis label
3 participants
@cjyetman @jdhoffa @MonikaFu