Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase font size for table header #87

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

MonikaFu
Copy link
Collaborator

@MonikaFu MonikaFu commented Jul 5, 2024

In this PR I add css specs for table font size so that a table with a header has the same sized header as the rest of the text.

This PR is related (but not required for it to work) to the update of general templates: https://github.com/RMI-PACTA/templates.transition.monitor/pull/23

Testing the results here: RMI-PACTA/workflow.transition.monitor#343 (table in the annex)

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.81%. Comparing base (ce5accc) to head (ba291dd).

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #87   +/-   ##
=====================================
  Coverage   0.81%   0.81%           
=====================================
  Files         25      25           
  Lines       1596    1596           
=====================================
  Hits          13      13           
  Misses      1583    1583           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MonikaFu MonikaFu marked this pull request as draft July 5, 2024 13:13
@MonikaFu MonikaFu marked this pull request as ready for review July 9, 2024 11:26
@MonikaFu MonikaFu requested review from cjyetman and jdhoffa July 9, 2024 12:35
Copy link
Member

@cjyetman cjyetman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems a bit broad (will affect every table on the page), but ok with that if you're ok with that

@MonikaFu
Copy link
Collaborator Author

MonikaFu commented Jul 9, 2024

seems a bit broad (will affect every table on the page), but ok with that if you're ok with that

yes, I'm ok with that. Now we have this rule for other table-related tags which makes the table look very weird with the small font only in the header.

@MonikaFu MonikaFu merged commit 723fbd5 into main Jul 9, 2024
10 checks passed
@MonikaFu MonikaFu deleted the change-font-size-table-css branch July 9, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants