remove project_location_ext read-in
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a hold-over from the old PACTA_analysis days that is no longer used in any of our un-archived repos except here and two config files in workflow.transition.monitor (which I will remove once this is merged) https://github.com/search?q=org%3ARMI-PACTA+project_location_ext+NOT+is%3Aarchived&type=code
1 task
jdhoffa
approved these changes
Mar 25, 2024
cjyetman
added a commit
to RMI-PACTA/workflow.transition.monitor
that referenced
this pull request
Mar 25, 2024
- [x] depends on RMI-PACTA/pacta.portfolio.utils#26 `project_location_ext` is an old parameter used in `PACTA_analysis` that is no longer in use in any of our active repos (except here, and `pacta.portfolio.utils::set_web_parameters()` which is being removed in RMI-PACTA/pacta.portfolio.utils#26) https://github.com/search?q=org%3ARMI-PACTA+project_location_ext+NOT+is%3Aarchived&type=code ℹ️ As I understand it, the working directory is used implicitly instead of what this parameter used to set explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hold-over from the old PACTA_analysis days that is no longer used in any of our un-archived repos except here and two config files in workflow.transition.monitor (which I will remove once this is merged)
https://github.com/search?q=org%3ARMI-PACTA+project_location_ext+NOT+is%3Aarchived&type=code
project_location_extworkflow.transition.monitor#289