Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combine "empty_*" functions into one file #40

Merged
merged 2 commits into from
Apr 27, 2024
Merged

combine "empty_*" functions into one file #40

merged 2 commits into from
Apr 27, 2024

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman requested a review from jdhoffa April 26, 2024 22:09
@jdhoffa
Copy link
Member

jdhoffa commented Apr 27, 2024

NIT/style/NB: maybe call it empty.R? Having the filename end in an underscore always looks a bit odd to me

@cjyetman
Copy link
Member Author

I don't love it, but it's a strong indicator to me that it's not just for an empty() function

@cjyetman cjyetman merged commit f00b1a4 into main Apr 27, 2024
7 checks passed
@cjyetman cjyetman deleted the combine-empty-functions-into-one-file branch April 27, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maybe combine all empty_data functions into one R/empty_datasets.R file
2 participants
@cjyetman @jdhoffa