-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider renaming by_groups
to by_group
otherwise LGTM (i think, it's a pretty mammoth PR so I may have missed something)
I run it with test data provided and using the two versions of the supporting packages mentioned. It seems to work correctly in general. For some plots the axis labels overlap with the title but since this is only a demo I am not sure if it is worth it to spend time on it. I guess you would need to play around with figure size when saving. Also - the sankey plot per company is rather unreadable which is to be expected with a big number of companies. |
I agree, especially re sankey plot with companies. In the end we need to decide what we want to maintain there. At the same time, we could just as well show examples using other variables with less categories. In any case, this seems like a topic for discussing the standardized P4S offering |
depends on RMI-PACTA/pacta.multi.loanbook.analysis#34
depends on RMI-PACTA/pacta.multi.loanbook.plot#30
pacta.multi.loanbook.*
functions to adjust to the new variable interfaceBY_GROUP
that can be used to generate aggregate metrics by any user defined variable, provided the variable exists in thematched_prioritized
data set"group_id"
"foo"
"group_id"
and"foo"
, giving a sub loan book viewNOTE:
EXAMPLE OUTPUTS with new grouping functionality
Sankey plot at the aggregate level:
Sankey plot calculated based on the
foo
split:Sankey plot calculated based on the
group_id
split:Scatter plot alignment by exposure based on
foo
split:Scatter plot alignment by exposure based on
group_id
split: