Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to workflow.pacta as a base image #41

Open
jdhoffa opened this issue Jan 22, 2024 · 10 comments
Open

Point to workflow.pacta as a base image #41

jdhoffa opened this issue Jan 22, 2024 · 10 comments
Labels
ADO Maintenance Day! breaking change ☠️ API change likely to affect existing code priority

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Jan 22, 2024

A new repository called workflow.pacta seems to (maybe?) have the goal of superseding the existing workflow.transition.monitor workflow. Whatever the "core PACTA engine" ends up being, this repository should make use of that as a base image.

AB#10658

@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 22, 2024

@cjyetman i think we are not actually ready to do this yet, but maybe something we will work toward?

@cjyetman
Copy link
Member

🤷🏻 workflow.pacta is kinda out of my hands now, but generally speaking I would support this

@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 31, 2024

@AlexAxthelm thoughts?

@AlexAxthelm
Copy link
Contributor

makes sense to me. Maybe wait a day or two though, since I'm planning on doing some work on workflow.pacta later today and tomorrow

@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 31, 2024

All good. The main question was more or less is workflow.pacta an experiment, or is it superseding existing PACTA. Sounds like the latter is true.

@cjyetman
Copy link
Member

All good. The main question was more or less is workflow.pacta an experiment, or is it superseding existing PACTA. Sounds like the latter is true.

I think we need to think about this carefully. Although long term I hope workflow.pacta supersedes existing PACTA workflows, in the medium term we still need to support workflow.transition.monitor. And my super cautious side thinks we should build indices for/on the same workflow they are intended to be used with.

@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 31, 2024

This is the discussion I wanted to spark! haha

@jdhoffa jdhoffa added the breaking change ☠️ API change likely to affect existing code label Feb 6, 2024
@jdhoffa
Copy link
Member Author

jdhoffa commented Feb 6, 2024

Important takeaway from a recent discussion:
DO NOT DO THIS UNTIL PACTA COP IS OVER.

@AlexAxthelm
Copy link
Contributor

DO NOT DO THIS UNTIL PACTA COP IS OVER.

DO NOT DO THIS UNTIL DATA PREP for PACTA COP IS OVER.

@jdhoffa
Copy link
Member Author

jdhoffa commented Feb 6, 2024

Given that in the past we have had to run data prep upwards of 20 times, I don't know if there is a clear point that data prep is "over"

So I think best to wait until COP is actually over haha

(Obviously I very much hope that this time is not like that, but just trying to plan for reality)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADO Maintenance Day! breaking change ☠️ API change likely to affect existing code priority
Projects
None yet
Development

No branches or pull requests

3 participants