Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github action to run index prep #94

Merged
merged 13 commits into from
Apr 29, 2024
Merged

Add github action to run index prep #94

merged 13 commits into from
Apr 29, 2024

Conversation

AlexAxthelm
Copy link
Contributor

@AlexAxthelm AlexAxthelm commented Apr 26, 2024 •
edited
Loading

Create a GH action to run index prep. Primarily structurted for inclusion into workflow.transition.monitor GH Actions build pipeline

@AlexAxthelm AlexAxthelm marked this pull request as ready for review April 29, 2024 10:28
jdhoffa
jdhoffa requested changes Apr 29, 2024
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment about where we should be specifying the filepath for the input data (just to keep it in line with the style that our other repos follow) but otherwise LGTM

@jdhoffa jdhoffa self-requested a review April 29, 2024 10:47
@AlexAxthelm AlexAxthelm linked an issue Apr 29, 2024 that may be closed by this pull request
Set up automated index prep #92
Closed
jdhoffa
jdhoffa approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, recognizing that our indices preparation process could use some re-thinking overall

@AlexAxthelm AlexAxthelm merged commit a14e0d9 into main Apr 29, 2024
2 checks passed
@AlexAxthelm AlexAxthelm deleted the gh-actions branch April 29, 2024 10:52
This was referenced Apr 29, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up automated index prep
2 participants
@AlexAxthelm @jdhoffa