Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build/336 update peer data #340

Merged
merged 16 commits into from
Jul 17, 2024
Merged

Build/336 update peer data #340

merged 16 commits into from
Jul 17, 2024

Conversation

AlexAxthelm
Copy link
Collaborator

@AlexAxthelm AlexAxthelm commented Jul 4, 2024 •
edited
Loading

Update build config to include actual PA2024CH peer files.

Note that they are in pactadatadev for now, rather than pactaportfolios (as was used to create them with https://github.com/RMI-PACTA/workflow.meta.report.data.creator/) due to permissions issues.

That will probably change in the future, once we've set up a different mechanism for authenticating the GH runners.

@AlexAxthelm AlexAxthelm linked an issue Jul 4, 2024 that may be closed by this pull request
Add PA2024CH peer results to build configuration #336
Open
@AlexAxthelm AlexAxthelm changed the base branch from main to jdhoffa-patch-1 July 15, 2024 11:18
@jdhoffa jdhoffa mentioned this pull request Jul 15, 2024
Merged
@jdhoffa jdhoffa self-requested a review July 15, 2024 11:24
@jdhoffa
Copy link
Member

jdhoffa commented Jul 15, 2024

Self-requesting as reviewer since this PR now targets the PR branch: #333

(as per #333 (comment) )

jdhoffa
jdhoffa approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions GitHub Actions
Copy link

Docker build status

commit_time git_sha project_code holdings_date language peer_group report summary download_command image
2024-07-17T08:32:56Z e39689f, GENERAL 2022Q4 EN other az storage copy --recursive --source https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2022q4_general-20240717T083853Z/EN/other/1/working_dir/50_Outputs/rmi_pacta_2022q4_general --destination rmi_pacta_2022q4_general-EN-other transitionmonitordockerregistry.azurecr.io/rmi_pacta_2022q4_general:20240717T083853Z
2024-07-17T08:32:56Z e39689f, GENERAL 2023Q4 EN other az storage copy --recursive --source https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_general-20240717T083853Z/EN/other/1/working_dir/50_Outputs/rmi_pacta_2023q4_general --destination rmi_pacta_2023q4_general-EN-other transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_general:20240717T083853Z
2024-07-17T08:32:56Z e39689f, PA2024CH 2023Q4 DE bank az storage copy --recursive --source https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports-private/rmi_pacta_2023q4_pa2024ch-20240717T083854Z/DE/bank/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch --destination rmi_pacta_2023q4_pa2024ch-DE-bank transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240717T083854Z
2024-07-17T08:32:56Z e39689f, PA2024CH 2023Q4 DE other az storage copy --recursive --source https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports-private/rmi_pacta_2023q4_pa2024ch-20240717T083854Z/DE/other/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch --destination rmi_pacta_2023q4_pa2024ch-DE-other transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240717T083854Z
2024-07-17T08:32:56Z e39689f, PA2024CH 2023Q4 EN assetmanager az storage copy --recursive --source https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports-private/rmi_pacta_2023q4_pa2024ch-20240717T083854Z/EN/assetmanager/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch --destination rmi_pacta_2023q4_pa2024ch-EN-assetmanager transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240717T083854Z
2024-07-17T08:32:56Z e39689f, PA2024CH 2023Q4 EN bank az storage copy --recursive --source https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports-private/rmi_pacta_2023q4_pa2024ch-20240717T083854Z/EN/bank/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch --destination rmi_pacta_2023q4_pa2024ch-EN-bank transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240717T083854Z
2024-07-17T08:32:56Z e39689f, PA2024CH 2023Q4 EN insurance az storage copy --recursive --source https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports-private/rmi_pacta_2023q4_pa2024ch-20240717T083854Z/EN/insurance/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch --destination rmi_pacta_2023q4_pa2024ch-EN-insurance transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240717T083854Z
2024-07-17T08:32:56Z e39689f, PA2024CH 2023Q4 EN other az storage copy --recursive --source https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports-private/rmi_pacta_2023q4_pa2024ch-20240717T083854Z/EN/other/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch --destination rmi_pacta_2023q4_pa2024ch-EN-other transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240717T083854Z
2024-07-17T08:32:56Z e39689f, PA2024CH 2023Q4 EN pensionfund az storage copy --recursive --source https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports-private/rmi_pacta_2023q4_pa2024ch-20240717T083854Z/EN/pensionfund/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch --destination rmi_pacta_2023q4_pa2024ch-EN-pensionfund transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240717T083854Z
2024-07-17T08:32:56Z e39689f, PA2024CH 2023Q4 FR bank az storage copy --recursive --source https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports-private/rmi_pacta_2023q4_pa2024ch-20240717T083854Z/FR/bank/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch --destination rmi_pacta_2023q4_pa2024ch-FR-bank transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240717T083854Z
2024-07-17T08:32:56Z e39689f, PA2024CH 2023Q4 FR other az storage copy --recursive --source https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports-private/rmi_pacta_2023q4_pa2024ch-20240717T083854Z/FR/other/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch --destination rmi_pacta_2023q4_pa2024ch-FR-other transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240717T083854Z
2024-07-17T08:32:56Z e39689f ghcr.io/rmi-pacta/workflow.transition.monitor:pr340

@AlexAxthelm AlexAxthelm marked this pull request as ready for review July 17, 2024 09:28
jdhoffa
jdhoffa approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jdhoffa jdhoffa merged commit 0c40429 into jdhoffa-patch-1 Jul 17, 2024
22 checks passed
@jdhoffa jdhoffa deleted the build/336-update-peer-data branch July 17, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

@cjyetman cjyetman Awaiting requested review from cjyetman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PA2024CH peer results to build configuration
3 participants
@AlexAxthelm @jdhoffa @cjyetman