Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing files with extra JSON Array #388

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Conversation

AlexAxthelm
Copy link
Collaborator

@AlexAxthelm AlexAxthelm commented Nov 3, 2024

In support of RMI-PACTA/pacta.portfolio.report#97

Allows for testing user_results directories at non-standard blob locations.

@jdhoffa
Copy link
Member

jdhoffa commented Nov 3, 2024

@AlexAxthelm CI build seems to be failing, but it seems totally unrelated to the changes in RMI-PACTA/pacta.portfolio.report#97.

It looks like we're missing a crucial file in the blob storage test for the extra_array user_results.

Looking into it

@jdhoffa
Copy link
Member

jdhoffa commented Nov 3, 2024

I really can't figure out what is going on with these failures.
I have checked and the file outputs/extra_array/user_data/128/PA2024CH/score_card/number_peers.csv does in fact exist on the blob store... so I honestly have no idea what is causing this to fail.

@AlexAxthelm
Copy link
Collaborator Author

The issue is that when we download the user results, they aren't in the right location to be mounted to the docker image, so we move them (using unix mv).

This PR now includes a change such that the testing pipeline can handle user results located somewhere other than <blob_container>/outputs/user_data/$USER_ID (for example, the files for testing with the new JSON files are at outputs/extra_array/user_data/$USER_ID

@AlexAxthelm AlexAxthelm marked this pull request as ready for review November 4, 2024 11:40
Copy link

github-actions bot commented Nov 4, 2024

Docker build status

commit_time git_sha project_code holdings_date language peer_group report summary image
2024-11-04T10:57:40Z 8b23a42, GENERAL 2022Q4 EN other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2022q4_general:20241104T110032Z
2024-11-04T10:57:40Z 8b23a42, GENERAL 2023Q4 EN other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_general:20241104T110030Z
2024-11-04T10:57:40Z 8b23a42, PA2024CH 2023Q4 DE bank Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241104T110033Z
2024-11-04T10:57:40Z 8b23a42, PA2024CH 2023Q4 DE other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241104T110033Z
2024-11-04T10:57:40Z 8b23a42, PA2024CH 2023Q4 EN assetmanager Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241104T110033Z
2024-11-04T10:57:40Z 8b23a42, PA2024CH 2023Q4 EN bank Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241104T110033Z
2024-11-04T10:57:40Z 8b23a42, PA2024CH 2023Q4 EN insurance Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241104T110033Z
2024-11-04T10:57:40Z 8b23a42, PA2024CH 2023Q4 EN other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241104T110033Z
2024-11-04T10:57:40Z 8b23a42, PA2024CH 2023Q4 EN pensionfund Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241104T110033Z
2024-11-04T10:57:40Z 8b23a42, PA2024CH 2023Q4 FR bank Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241104T110033Z
2024-11-04T10:57:40Z 8b23a42, PA2024CH 2023Q4 FR other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241104T110033Z
2024-11-04T10:57:40Z 8b23a42, PA2024CH_sectoral 2023Q4 DE other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch_sectoral:20241104T110030Z
2024-11-04T10:57:40Z 8b23a42, PA2024CH_sectoral 2023Q4 EN other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch_sectoral:20241104T110030Z
2024-11-04T10:57:40Z 8b23a42, PA2024CH_sectoral 2023Q4 FR other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch_sectoral:20241104T110030Z
2024-11-04T10:57:40Z, 8b23a42, "ghcr.io/rmi-pacta/workflow.transition.monitor:pr-388"

Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!!

@AlexAxthelm AlexAxthelm merged commit 8527fd4 into main Nov 4, 2024
28 checks passed
@AlexAxthelm AlexAxthelm deleted the secret-bonus-json-array branch November 4, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants