ostream operator overload (StepTimeData) now returns ostream instance #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::ostream operator overload for `StepTimeData` was previously returning void, which lead to some unexpected behavior with ostream operator chaining. Signed-off-by: Abrar Rahman Protyasha <aprotyas@u.rochester.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::ostream operator overload for
StepTimeDatawas previouslyreturning void, which lead to some unexpected behavior with
ostream operator chaining.
I simply added a return statement to patch this issue.
That should be all unless I'm missing some context here.
Signed-off-by: Abrar Rahman Protyasha aprotyas@u.rochester.edu