Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

[OMPIRBuilder] Fix collapse test case #256

Merged

Conversation

DominikAdamski
Copy link
Contributor

No description provided.

Copy link
Contributor

@skatrak skatrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

for (auto Use = CLI->getIndVar()->user_begin();
Use != CLI->getIndVar()->user_end(); ++Use) {
if (Instruction *Inst = dyn_cast<Instruction>(*Use)) {
std::vector<User *> Users(CLI->getIndVar()->user_begin(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Maybe it's better to use llvm::SmallVector?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@dpalermo dpalermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpalermo dpalermo merged commit f91690c into ROCm-Developer-Tools:amd-trunk-dev Jan 9, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants