Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated reduceDims for NCHW and NHWC layouts for Backward CK #3259

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

xinlipn
Copy link
Contributor

@xinlipn xinlipn commented Sep 18, 2024

Use reduceDims for switching NCHW and NHWC layouts with CK

@xinlipn xinlipn changed the title Updated reduceDims for NCHW and NHWC layouts Updated reduceDims for NCHW and NHWC layouts for Backward CK Sep 19, 2024
@xinlipn xinlipn marked this pull request as draft September 30, 2024 15:24
@bghimireamd
Copy link
Contributor

bghimireamd commented Oct 17, 2024

I think we need to enable NCHW in IsApplicable of the solver too. Same goes for other solvers too.

@xinlipn
Copy link
Contributor Author

xinlipn commented Oct 21, 2024

I think we need to enable NCHW in IsApplicable of the solver too. Same goes for other solvers too.

@bghimireamd , done for this PR and the other two as well PR3227 and 3260

@xinlipn xinlipn marked this pull request as ready for review October 23, 2024 17:05
@averinevg
Copy link
Collaborator

@xinlipn @junliume #3332 has been merged, this PR can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants