move tensor_holder.hpp and gpuMemTensor.hpp from test to src #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averinevg
requested changes
Oct 3, 2024
There was a problem hiding this comment.
This PR expose
tensor_holder.hppandgpuMemTensor.hppheaders outside of the current module.
We shouldn't do that. This code is not used within the library itself and will only pollute it. We should not mix test and library code.
This change allows third-party libraries to directly include and utilize the MIOpen's tensor holder functionality that help easy data initialization and transfer between cpu and gpu.
These are our internal helpers. Third-party libraries should have their own stuff.
|
We need to discuss it one more time. |
|
PR no longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expose
tensor_holder.hppandgpuMemTensor.hppheaders outside of the current module. This change allows third-party libraries to directly include and utilize the MIOpen's tensor holder functionality that help easy data initialization and transfer between cpu and gpu.