Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct hipsparseLtGetProperty function name #162

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Correct hipsparseLtGetProperty function name #162

merged 1 commit into from
Oct 23, 2024

Conversation

harkgill-amd
Copy link
Contributor

Fix for #157.

Correct typo from hipsparseLtGetPorperty to hipsparseLtGetProperty in library/src/hcc_detail/hipsparselt.cpp.

@vin-huang vin-huang added the gfx94x Run CI on gfx94x label Oct 23, 2024
vin-huang
vin-huang approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@vin-huang vin-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but need to wait for the CI completed before merging.

@vin-huang vin-huang mentioned this pull request Oct 23, 2024
Merged
@vin-huang
Copy link
Collaborator

The CI seems not running,
Used local test instead.

The local test is passed.
[----------] Global test environment tear-down
[==========] 105252 tests from 4 test suites ran. (3778249 ms total)
[ PASSED ] 105252 tests.
hipSPARSELt version: 202

@vin-huang vin-huang merged commit 16d3052 into ROCm:develop Oct 23, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vin-huang vin-huang vin-huang approved these changes

@jichangjichang jichangjichang Awaiting requested review from jichangjichang jichangjichang is a code owner

@hcman2 hcman2 Awaiting requested review from hcman2 hcman2 is a code owner

@imcarsonliao imcarsonliao Awaiting requested review from imcarsonliao imcarsonliao is a code owner

Assignees
No one assigned
Labels
gfx94x Run CI on gfx94x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harkgill-amd @vin-huang