[NFC][Clang][TableGen] Use StringRef in FlattenedSpelling (llvm#113809)

- Change FlattenedSpelling to use StringRef instead of std::String.
- Use range for loops and enumerate().
- Use ArrayRef<> instead of std::vector reference as function arguments.
- Use {} for all if/else branch bodies if one of them uses it.