[Flang][OpenMP] Remove unnecessary handling for loop wrappers #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code removed by this patch was added with the intention of preventing the use of regions belonging to loop wrapper operations as a point to insert allocations. However, this issue is only present for `omp.parallel` wrappers, which are handled right before this piece of code. The result is that any operations that are currently captured by this piece of code would be handled correctly by letting execution of the `getAllocaBlock()` method continue and return the entry block of the parent `func.func` operation.
skatrak
requested review from
ergawy,
jsjodin,
abidh,
mjklemm,
raghavendhra,
agozillon,
DominikAdamski,
TIFitis,
kparzysz and
bhandarkar-pranav
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code removed by this patch was added with the intention of preventing the use of regions belonging to loop wrapper operations as a point to insert allocations. However, this issue is only present for
omp.parallelwrappers, which are handled right before this piece of code.The result is that any operations that are currently captured by this piece of code would be handled correctly by letting execution of the
getAllocaBlock()method continue and return the entry block of the parentfunc.funcoperation.