Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flang][MLIR][OpenMP] Fix num_teams, num_threads, thread_limit lowering #132

Merged
merged 2 commits into from
Aug 9, 2024

Commits on Aug 7, 2024

  1. [Flang][MLIR][OpenMP] Fix num_teams, num_threads, thread_limit lowering

    This patch fixes lowering for the num_teams, num_threads and thread_limit
    clauses when inside of a target region and compiling for the host device.
    
    The current approach requires these to be attached to the parent MLIR
    omp.target operation. However, some incorrect checks based on the
    `evalHasSiblings()` helper function would result in these clauses being
    attached to the `omp.teams` or `omp.parallel` operation instead, triggering
    a verifier error.
    
    In this patch, these checks are updated to stop breaking when lowering
    combined `target teams [X]` constructs. Also, the `genTeamsClauses()` function
    is fixed to avoid processing num_teams and thread_limit twice, which probably
    resulted from a recent merge.
    skatrak committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    2923592 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Configuration menu
    Copy the full SHA
    dbbfdba View commit details
    Browse the repository at this point in the history