Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flang][OpenMP] Privatize "loop-local" values in do concurent on device #146

Merged

Conversation

ergawy
Copy link

@ergawy ergawy commented Aug 19, 2024

Extends #112.

This PR extends support for do concurrent mapping to the device a bit more. In particular, it handles localization of loop-local values on the deive. Previously, this was only supported and tested on the host.

See docs for looputils::collectLoopLocalValues for the definition of "loop-local" values.

@ergawy ergawy changed the title [flang][OpenMP] Privatize "loop-local" values in do concurent on de… [flang][OpenMP] Privatize "loop-local" values in do concurent on device Aug 19, 2024
@ergawy ergawy force-pushed the do_concurrent_locally_destroyed_value_device branch from ad3ac5d to f515705 Compare August 19, 2024 09:51
…vice

Extends ROCm#112.

This PR extends support for `do concurrent` mapping to the device a bit
more. In particular, it handles localization of loop-local values on the
deive. Previously, this was only supported and tested on the host.

See docs for `looputils::collectLoopLocalValues` for the definition of
"loop-local" values.
@ergawy ergawy force-pushed the do_concurrent_locally_destroyed_value_device branch from f515705 to 3790250 Compare August 19, 2024 09:53
Copy link

@skatrak skatrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thank you.

@ergawy ergawy merged commit 5c0cc18 into ROCm:amd-trunk-dev Aug 19, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants