Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OMPIRBuilder] NFC: Remove unused functions #156

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

skatrak
Copy link

@skatrak skatrak commented Sep 6, 2024

This patch removes some internal functions from the OMPIRBuilder that are not used and do not exist upstream. They seem to have been left behind after some merge or improvements to reductions support made them redundant.

This patch removes some internal functions from the OMPIRBuilder that are not
used and do not exist upstream. They seem to have been left behind after some
merge or improvements to reductions support made them redundant.
@skatrak skatrak requested a review from jsjodin September 6, 2024 14:02
@skatrak skatrak changed the title [OMPIRBuilder] Remove unused functions [OMPIRBuilder] NFC: Remove unused functions Sep 6, 2024
Copy link

@jsjodin jsjodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skatrak skatrak merged commit fdfa0a1 into ROCm:amd-trunk-dev Sep 10, 2024
3 of 5 checks passed
@skatrak skatrak deleted the ompirbuilder-cleanup branch September 10, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants