Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aomp/test/smoke-fort/flang-471469 #158

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

TIFitis
Copy link

@TIFitis TIFitis commented Sep 17, 2024

No description provided.

@dpalermo
Copy link

No longer asserts, but there is now a memory access fault at runtime (could be a separate issue):

[r5 ~/git/aomp20.0/aomp/test/smoke-fort/flang-471469]$ AOMP=/work1/omp-nightly/build/rocm/trunk-atd_20.0-0 make run
Makefile:32: warning: overriding recipe for target 'test'
../Makefile.rules:59: warning: ignoring old recipe for target 'test'
mkdir -p obj
/work1/omp-nightly/build/rocm/trunk-atd_20.0-0/bin/clang -x hip -O3 --offload-arch=gfx90a -c kernel.cpp -o obj/kernel.o
/work1/omp-nightly/build/rocm/trunk-atd_20.0-0/bin/flang-new -O2 -fopenmp -fopenmp-version=50 --offload-arch=gfx90a -c driver.f90 -o obj/driver.o
/work1/omp-nightly/build/rocm/trunk-atd_20.0-0/bin/flang-new -O2 -fopenmp -fopenmp-version=50 --offload-arch=gfx90a -O3 -L/opt/rocm/lib -lamdhip64 -lstdc++ -o test obj/driver.o obj/kernel.o
rm -rf obj
./test  2>&1 | tee run.log
Calling HIP vector_add
No kernel launches known
OFFLOAD ERROR: Memory access fault by GPU 4 (agent 0xfb8d40) at virtual address 0xfca000. Reasons: Unknown (0)
Use 'OFFLOAD_TRACK_ALLOCATION_TRACES=true' to track device allocations
/bin/bash: line 1: 2134469 Aborted                 (core dumped) ./test 2>&1
     2134470 Done                    | tee run.log
make: *** [../Makefile.rules:78: run] Error 134

Copy link

@skatrak skatrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Akash! I think we can merge this, since it gets us a bit closer to getting the issues sorted.

Copy link

@agozillon agozillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TIFitis TIFitis merged commit 8688adb into ROCm:amd-trunk-dev Sep 18, 2024
2 of 4 checks passed
@dpalermo
Copy link

Latest commit has resolved the runtime error:

[r5 ~/git/aomp20.0/aomp/test/smoke-fort/flang-471469]$ AOMP=/work1/omp-nightly/build/rocm/trunk-atd make
 run
Makefile:32: warning: overriding recipe for target 'test'
../Makefile.rules:59: warning: ignoring old recipe for target 'test'
mkdir -p obj
/work1/omp-nightly/build/rocm/trunk-atd/bin/clang -x hip -O3 --offload-arch=gfx90a -c kernel.cpp -o obj/kernel.o
/work1/omp-nightly/build/rocm/trunk-atd/bin/flang-new -O2 -fopenmp -fopenmp-version=50 --offload-arch=gfx90a -c driver.f90 -o obj/driver.o
/work1/omp-nightly/build/rocm/trunk-atd/bin/flang-new -O2 -fopenmp -fopenmp-version=50 --offload-arch=gfx90a -O3 -L/opt/rocm/lib -lamdhip64 -lstdc++ -o test obj/driver.o obj/kernel.o
rm -rf obj
./test  2>&1 | tee run.log
Calling HIP vector_add
Finished HIP vector_add
 c(1) =  3.
echo > /dev/null 2>&1 | tee -a run.log

@TIFitis TIFitis deleted the regression_fix branch September 23, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants