[MLIR][OpenMP] Introduce host_eval clause to omp.target #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skatrak
requested review from
ergawy,
jsjodin,
mjklemm,
agozillon,
DominikAdamski,
TIFitis,
kparzysz and
bhandarkar-pranav
This was referenced Oct 10, 2024
skatrak
force-pushed
the
users/skatrak/target-passthrough-02-mlir
branch
from
44b6230
to
719e50c
Compare
skatrak
changed the base branch from
users/skatrak/target-passthrough-01-block-args
to
amd-trunk-dev
skatrak
force-pushed
the
users/skatrak/target-passthrough-02-mlir
branch
from
719e50c
to
bc6485b
Compare
bhandarkar-pranav
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Thank you for this PR, @skatrak. I have one nit in the code and 2-3 suggestions in the docs part of the PR. Of course, the suggestions for the docs are entirely subjective, so please take with a grain of salt. Otherwise, LGTM.
skatrak
force-pushed
the
users/skatrak/target-passthrough-02-mlir
branch
from
bc6485b
to
ad391a1
Compare
|
Thanks for the review @bhandarkar-pranav, your comments should be addressed now. |
bhandarkar-pranav
approved these changes
Oct 28, 2024
skatrak
force-pushed
the
users/skatrak/target-passthrough-02-mlir
branch
from
ad391a1
to
595f1ae
Compare
This patch defines a map-like clause named `host_eval` used to capture host values for use inside of target regions on restricted cases: - As `num_teams` or `thread_limit` of a nested `omp.target` operation. - As `num_threads` of a nested `omp.parallel` operation or as bounds or steps of a nested `omp.loop_nest`, if it is a target SPMD kernel. This replaces the following `omp.target` arguments: `trip_count`, `num_threads`, `num_teams_lower`, `num_teams_upper` and `teams_thread_limit`.
skatrak
force-pushed
the
users/skatrak/target-passthrough-02-mlir
branch
from
595f1ae
to
f33594a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch defines a map-like clause named
host_evalused to capture host values for use inside of target regions on restricted cases:num_teamsorthread_limitof a nestedomp.targetoperation.num_threadsof a nestedomp.paralleloperation or as bounds or steps of a nestedomp.loop_nest, if it is a target SPMD kernel.This replaces the following
omp.targetarguments:trip_count,num_threads,num_teams_lower,num_teams_upperandteams_thread_limit.Since it's an entry block argument-generating clause, custom region parsers/printers and the
BlockArgOpenMPOpInterfaceare updated.