[flang][OpenMP] Fix FlangRuntime offload build after assign change #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpalermo
commented
Nov 8, 2024
dpalermo
commented
- Use actual function for memmove (address taken)
|
Fixed needed after change in llvm#114301 |
dpalermo
requested review from
ergawy,
mjklemm,
bcornille,
agozillon and
DominikAdamski
|
Also interesting, but the pre-existing libc replacement memmove was missing a return value on the early exit case. Now fixed. Reported as a compilation error after no longer using the memmove builtin. |
|
Raghu noticed the GenASiS target test was no longer finding -lFortranRuntimeHostDevice ...as the build of libFortranRuntimeHostDevice.a was failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.