Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLIR][OpenMP] Add case for TargetDataOp when traversing inner regions #57

Merged
merged 1 commit into from
Mar 28, 2024
Merged

[MLIR][OpenMP] Add case for TargetDataOp when traversing inner regions #57

merged 1 commit into from
Mar 28, 2024

Conversation

jsjodin
Copy link

@jsjodin jsjodin commented Mar 28, 2024

No description provided.

skatrak
skatrak approved these changes Mar 28, 2024
View reviewed changes
Copy link

@skatrak skatrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe when upstreaming it adding a unit test would be nice as well. Thanks!

@jsjodin
Copy link
Author

jsjodin commented Mar 28, 2024

LGTM, maybe when upstreaming it adding a unit test would be nice as well. Thanks!

Yes, we'll have to add several tests for this.

@jsjodin jsjodin merged commit 130977f into amd-trunk-dev Mar 28, 2024
3 checks passed
@jsjodin jsjodin deleted the jleyonberg/dataopcase branch March 28, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skatrak skatrak skatrak approved these changes

@gregrodgers gregrodgers Awaiting requested review from gregrodgers

@dpalermo dpalermo Awaiting requested review from dpalermo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjodin @skatrak