[Flang][MLIR][OpenMP] Initial multi-layered derived type member map support #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport This PR adds explicit derived type member mapping for nested descriptor types (allocatables) and other types, allowing users to map specific components of a derived type rather than the whole derived type. Currently this would also be the only way to map descriptor types within a derived type, as the automagic mapping of these when mapping an entire derived type is still a WIP and should follow on from this work. There's a lot of Fortran tests added in this PR that should give examples of what kind of mappings are handled in this PR. This PR shouldn't (at least from self testing) regress any existing map behaviour just add on to it.
agozillon
requested review from
skatrak,
jsjodin,
raghavendhra,
DominikAdamski and
TIFitis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit derived type member mapping for nested descriptor types (allocatables) and other types, allowing users to map specific components of a derived type rather than the whole derived type. Currently this would also be the only way to map descriptor types within a derived type, as the automagic mapping of these when mapping an entire derived type is still a WIP and should follow on from this work.
There's a lot of Fortran tests added in this PR that should give examples of what kind of mappings are handled in this PR. This PR shouldn't (at least from self testing) regress any existing map behaviour just add on to it.