Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flang][OpenMP] Share DataSharingProcessing instance for simd loops #66

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

ergawy
Copy link

@ergawy ergawy commented Apr 24, 2024

For !$omp target ... constructs, we need to share the DSP instance to prevent privatization for the same variable from happening more than once. This was partially the case already. However, we forgot to do so for simd variants of the construct. This commit fixes the issue.

This partially fixes: https://ontrack-internal.amd.com/browse/SWDEV-446525.

For `!$omp target ...` constructs, we need to share the DSP instance to
prevent privatization for the same variable from happening more than
once. This was partially the case already. However, we forgot to do so
for `simd` variants of the construct. This commit fixes the issue.
Copy link

@skatrak skatrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ergawy ergawy merged commit b8baaa8 into ROCm:amd-trunk-dev Apr 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants